Skip to content

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #11161

/assign austinvazquez

Signed-off-by: Henry Wang <henwang@amazon.com>
Signed-off-by: Henry Wang <henwang@amazon.com>
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@samuelkarp
Copy link
Member

  Error: integration/container_tty_leak_linux_test.go:123:13: undefined: connectToShim (typecheck)
  	shimCli := connectToShim(ctx, t, containerdEndpoint, 3, sb)
  	           ^
  Error: integration/container_tty_leak_linux_test.go:124:13: undefined: shimPid (typecheck)
  	return int(shimPid(ctx, t, shimCli))
  	           ^

Do we need another commit to be cherry-picked first?

@austinvazquez
Copy link
Member

Yep, I may need to manually bring this back. I wonder if I get write perms to the cherry-pick branch since I did the command.

@samuelkarp
Copy link
Member

I wonder if I get write perms to the cherry-pick branch since I did the command.

I don't think so; k8s-infra-cherrypick-robot owns the PR and branch. Maintainers with write access on this repo have access, but I think it's easier just to close and open a new one if you're going to manually bring it back.

@austinvazquez
Copy link
Member

Sounds good. Will close for now and manually handle 1.7 and 1.6 backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants