-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Publish attestation as release artifact #11049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish attestation as release artifact #11049
Conversation
Where to manually upload them to? Anything we can do for the 2.0.0 release as well after the fact to get them to show up? |
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
5a67ae4 to
3961dc9
Compare
Manually upload the containerd tarballs to GitHub. The case I was attempting to think through was we attest the artifacts but are unable to publish the release. It is probably unlikely but wanted to think through if this change adds any complexity to release.
Let me look into this. We have the attestation on GitHub so I can write a quick one time workflow to pull the 2.0 artifacts, attest, and manually upload the attestation as a build artifact. (Assuming attestations are reproducible; which should be easy to verify) |
|
Looking at https://github.com/austinvazquez/containerd/releases/tag/vnightly-11.24.24-1, Nice! |
|
Let's try it out for the next release |
@dmcgowan, I tried creating a workflow to pull the 2.0 artifacts and re-attest. TIL the attestation has some metadata which wouldn't be reproduced (i.e. the workflow, created timestamp, etc.) We can download the attestation for an individual release artifact. |
|
/cherry-pick release/2.0 |
|
@austinvazquez: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is strange, If the org membership is public, you should be able to use the cherry-pick plugin? 🤔 |
|
Oh, looks like the bot was correct. I had my membership private. Excited to try Going to let this bake on the next release before asking to take it back to other release branches. |
Followup to #10543 (review) to attest artifacts prior to creating the release. This also should address containerd project's signed releases action item in CNCF CLO monitor Reference: containerd CLO monitor, scorecard checks doc
This allows the attestation to be published with the release artifacts. The trade-off is if create release were to fail (potentially due to GitHub outage), then artifacts have already been attested and published to GitHub attestations. This should be an acceptable trade-off as maintainers with write access can manually upload the containerd tarballs to GitHub or roll forward release.
Tested in fork, see https://github.com/austinvazquez/containerd/actions/runs/12002403717