Skip to content

Revert "Disable vagrant strict dependency checking" #11004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuweid merged 1 commit into from
Nov 15, 2024
Merged

Revert "Disable vagrant strict dependency checking" #11004

fuweid merged 1 commit into from
Nov 15, 2024

Conversation

@akhilerm
Copy link
Member

@akhilerm akhilerm commented Nov 14, 2024

This reverts commit ae73e30.

Vagrant v2.4.3 is released (CHANGELOG), and has the fix mentioned in #10950

@dosubot dosubot bot added the area/github_actions Pull requests that update GitHub Actions code label Nov 14, 2024
@akhilerm
Revert "Disable vagrant strict dependency checking"
1b01f39 
This reverts commit ae73e30.

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm force-pushed the revert-vagrant-dependency-check branch from a7411b0 to 1b01f39 Compare November 14, 2024 08:54
thaJeztah
thaJeztah approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp added this pull request to the merge queue Nov 14, 2024
@estesp estesp added cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/1.6.x labels Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@fuweid fuweid added this pull request to the merge queue Nov 14, 2024
Merged via the queue into containerd:main with commit 66f7290 Nov 15, 2024
@akhilerm akhilerm deleted the revert-vagrant-dependency-check branch November 15, 2024 03:40
@akhilerm
Copy link
Member Author

akhilerm commented Nov 15, 2024

/cherry-pick release/2.0

@akhilerm
Copy link
Member Author

akhilerm commented Nov 15, 2024

/cherrypick release/2.0

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 15, 2024

@akhilerm: new pull request created: #11009

Details

In response to this:

/cherry-pick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 15, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 15, 2024

@akhilerm: new pull request could not be created: failed to create pull request against containerd/containerd#release/2.0 from head k8s-infra-cherrypick-robot:cherry-pick-11004-to-release/2.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-11004-to-release/2.0."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherrypick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akhilerm
Copy link
Member Author

akhilerm commented Nov 15, 2024

/cherry-pick release/1.7
/cherry-pick release/1.6

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 15, 2024

@akhilerm: new pull request created: #11010

Details

In response to this:

/cherry-pick release/1.7
/cherry-pick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 15, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 15, 2024

@akhilerm: new pull request created: #11011

Details

In response to this:

/cherry-pick release/1.7
/cherry-pick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 15, 2024
Merged
@akhilerm
Copy link
Member Author

akhilerm commented Nov 15, 2024

/cherry-pick release/1.7

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 15, 2024

@akhilerm: new pull request could not be created: failed to create pull request against containerd/containerd#release/1.7 from head k8s-infra-cherrypick-robot:cherry-pick-11004-to-release/1.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-11004-to-release/1.7."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@austinvazquez austinvazquez added the cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch label Nov 20, 2024
@austinvazquez austinvazquez added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Nov 20, 2024
This was referenced Nov 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@fuweid fuweid fuweid approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees

No one assigned

Labels

area/github_actions Pull requests that update GitHub Actions code cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@akhilerm @k8s-infra-cherrypick-robot @estesp @thaJeztah @fuweid @austinvazquez @k8s-ci-robot