[release/1.7] backport: Disable vagrant strict dependency checking#10965
Merged
Conversation
Fixes broken vagrant builds Signed-off-by: Derek McGowan <derek@mcg.dev> (cherry picked from commit ae73e30) Signed-off-by: Phil Estes <estesp@gmail.com>
akhilerm
reviewed
Nov 7, 2024
Comment on lines
+580
to
+581
| # https://github.com/vagrant-libvirt/vagrant-libvirt/issues/1725#issuecomment-1454058646 | ||
| sudo cp /usr/share/OVMF/OVMF_VARS_4M.fd /var/lib/libvirt/qemu/nvram/ |
Member
There was a problem hiding this comment.
Can you also add that this change is cherry-picked from 1db0064
Member
Author
There was a problem hiding this comment.
officially through git cherry-pick -x or you think it needs a comment?
Member
There was a problem hiding this comment.
I prefer the cherry-pick -x.
I think its still working fine without the other changes (setting nvram in vagrant file) in the above mentioned commit because we are still on ubuntu-22.04 in release branch. But once we upgrade we are anyway going to need those changes.
dims
approved these changes
Nov 7, 2024
dmcgowan
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken vagrant builds
From #10950
(cherry picked from commit ae73e30)