Skip to content

Avoid arch info in the sed/replace when building cri-cni-containerd.tar.gz #10964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikebrow merged 1 commit into from
Nov 7, 2024
Merged

Avoid arch info in the sed/replace when building cri-cni-containerd.tar.gz #10964

mikebrow merged 1 commit into from
Nov 7, 2024

Conversation

@dims
Copy link
Member

@dims dims commented Nov 7, 2024

Helps match tgz file name to the same format when we build under arm64 as well, we are only trying to change the - to . here and there's no need to specify amd64

@dims
Avoid arch info in the sed/replace when building cri-cni-containerd.t…
784116b 
…ar.gz

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dosubot dosubot bot added the area/toolchain Build and Release Toolchain label Nov 7, 2024
@dims
Copy link
Member Author

dims commented Nov 7, 2024

/assign @samuelkarp @mikebrow

@dims dims added cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Nov 7, 2024
mikebrow
mikebrow approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Nov 7, 2024
Closed
Merged
@mikebrow mikebrow added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 7, 2024
@mikebrow mikebrow added this pull request to the merge queue Nov 7, 2024
Merged via the queue into containerd:main with commit a78a24e Nov 7, 2024
This was referenced Nov 7, 2024
Merged
Merged
@austinvazquez austinvazquez added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

@samuelkarp samuelkarp

@mikebrow mikebrow

Labels

area/toolchain Build and Release Toolchain cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dims @estesp @mikebrow @samuelkarp @k8s-ci-robot @austinvazquez