metrics: Use UnmarshalTo instead of UnmarshalAny#10815
Merged
Merged
Conversation
samuelkarp
approved these changes
Oct 11, 2024
fuweid
approved these changes
Oct 11, 2024
Member
|
This will probably need to be rebased once we fix the Vagrant jobs: #10816 |
Co-authored-by: Sam Lockart <sam.lockart@zendesk.com> Signed-off-by: Iceber Gu <caiwei95@hotmail.com>
b9e2961 to
c6d0890
Compare
mxpv
approved these changes
Oct 15, 2024
Member
|
This PR was (pre)cherry-picked into #10814 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr comes from not updating #9195.
Although this bug will only happen in 1.7, for the consistency of the code, the main will be updated first, and then cherry picked to 1.7
related pr for release/1.7: #10814