Skip to content

[release/1.7] Add check for CNI plugins before tearing down pod network#10767

Merged
mxpv merged 1 commit intocontainerd:release/1.7from
sameersaeed:v1.7.22-sandbox-cni-plugins
Oct 4, 2024
Merged

[release/1.7] Add check for CNI plugins before tearing down pod network#10767
mxpv merged 1 commit intocontainerd:release/1.7from
sameersaeed:v1.7.22-sandbox-cni-plugins

Conversation

@sameersaeed
Copy link
Copy Markdown
Contributor

@sameersaeed sameersaeed commented Oct 3, 2024

Cherry pick of #10744 for release 1.7.22

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 3, 2024

Hi @sameersaeed. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the area/cri Container Runtime Interface (CRI) label Oct 3, 2024
mikebrow
mikebrow approved these changes Oct 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Oct 3, 2024

/ok-to-test

noting the package moved from pkg/ to internal/ in main...

mikebrow
mikebrow approved these changes Oct 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit 45967a7 into containerd:release/1.7 Oct 4, 2024
@dmcgowan dmcgowan mentioned this pull request Oct 8, 2024
Merged
@MrHohn MrHohn mentioned this pull request Jul 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

area/cri Container Runtime Interface (CRI) impact/changelog ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sameersaeed @k8s-ci-robot @mikebrow @mxpv @dmcgowan