Skip to content

[WIP]Update containerd/errdefs to v0.3.0#10693

Closed
yankay wants to merge 1 commit intocontainerd:mainfrom
yankay:update-errdefs-v0.2.0
Closed

[WIP]Update containerd/errdefs to v0.3.0#10693
yankay wants to merge 1 commit intocontainerd:mainfrom
yankay:update-errdefs-v0.2.0

Conversation

@yankay
Copy link
Contributor

@yankay yankay commented Sep 12, 2024

Update containerd/errdefsto v0.2.0 . A complete list of changes can be found here: https://github.com/containerd/errdefs/releases/tag/v0.2.0 .

Because of the containerd/errdefs#5 , there is a need to change the package import.

@dosubot dosubot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 12, 2024
@yankay yankay force-pushed the update-errdefs-v0.2.0 branch from 4428044 to 5aba65b Compare September 12, 2024 08:03
@yankay yankay mentioned this pull request Sep 12, 2024
Closed
@yankay
Copy link
Contributor Author

yankay commented Sep 12, 2024

HI @dmcgowan

Would you please help to review it :-)

@mauriciovasquezbernal mauriciovasquezbernal mentioned this pull request Sep 17, 2024
Closed
@yankay yankay changed the title Update containerd/errdefs to v0.2.0 [WIP]Update containerd/errdefs to v0.2.0 Sep 18, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request Sep 19, 2024
Closed
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Sep 19, 2024

CI is failing

@yankay
Copy link
Contributor Author

yankay commented Sep 19, 2024 •
edited
Loading

fix: #10478

The CI is blocked by

0.852 go build  -gcflags=-trimpath=/go/src  -o bin/ctr.exe -ldflags '-X github.com/containerd/containerd/v2/version.Version= -X github.com/containerd/containerd/v2/version.Revision=f269c475383abc1ad5b6e7757b48f7aa8ad64813 -X github.com/containerd/containerd/v2/version.Package=github.com/containerd/containerd/v2 -s -w ' -tags "urfave_cli_no_docs"  ./cmd/ctr
14.90 # github.com/Microsoft/hcsshim/internal/oc
14.90 vendor/github.com/Microsoft/hcsshim/internal/oc/errors.go:21:39: undefined: errdefs.ToGRPC
20.23 make: *** [Makefile.windows:32: bin/ctr.exe] Error 1

Because the hcsshim depends on errdefs v0.1.0. https://github.com/microsoft/hcsshim/blob/main/go.mod#L15

So, I tried to fix it by using microsoft/hcsshim#2263. But the CI is also blocked.

This PR is a bit difficult for me to complete alone; I hope it won't block the release.

@yankay yankay mentioned this pull request Sep 23, 2024
Closed
@pacoxu pacoxu mentioned this pull request Sep 23, 2024
Merged
@yankay yankay force-pushed the update-errdefs-v0.2.0 branch from 5aba65b to a81be1a Compare October 9, 2024 08:28
@yankay yankay changed the title [WIP]Update containerd/errdefs to v0.2.0 [WIP]Update containerd/errdefs to v0.3.0 Oct 9, 2024
@yankay yankay force-pushed the update-errdefs-v0.2.0 branch from a81be1a to 1fdf20c Compare October 9, 2024 08:30
@yankay
Update errdefs to v0.3.0
d9a5cc3 
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the update-errdefs-v0.2.0 branch from 1fdf20c to d9a5cc3 Compare October 9, 2024 09:31
@pacoxu
Copy link
Contributor

pacoxu commented Oct 22, 2024

/close
in favor of #10856

@k8s-ci-robot
Copy link

k8s-ci-robot commented Oct 22, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yankay yankay closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file do-not-merge/work-in-progress go Pull requests that update Go code needs-rebase size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yankay @AkihiroSuda @pacoxu @k8s-ci-robot