-
Notifications
You must be signed in to change notification settings - Fork 3.8k
KEP 4216: Implement support for image pull per runtime class #10533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
82ca06b to
5686042
Compare
5686042 to
b7e4029
Compare
fab0a9f to
a9b0c94
Compare
6c83e62 to
fefb511
Compare
fefb511 to
8e20a69
Compare
830be53 to
792e097
Compare
Adds support for image pull per runtime class with the help of gc labels. The image pull code path remains the same but during UpdateImage() call, the image index or manifest is walked to find the appropriate platform, snapshot the image was unpacked for. If such a match if found, find all matching runtime handlers with identical platform and snapshotter from CriConfig.RuntimePlatforms and update containerd and cri image stores appropriately. New entry for tuple (ref,runtimehandler) are made in containerd metadata store and snapshot gc labels are added to take reference on unpacked snapshot. Further, image gc labels are also added to the root image to ensure appropriate resource cleanup. This approach also makes the image delete and reload code paths simple. Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
b406b5d to
d65aec0
Compare
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
06c7471 to
4abbfb9
Compare
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
4abbfb9 to
fb15345
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
|
@kiashok will you be picking this up again? |
|
@kiashok: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Updated PR: #11807 |
Updated PR: #11807