Skip to content

Conversation

@kiashok
Copy link
Contributor

@kiashok kiashok commented Jul 31, 2024

Updated PR: #11807

@kiashok
Copy link
Contributor Author

kiashok commented Jul 31, 2024

@kiashok kiashok force-pushed the kep4216-gc-labels branch 3 times, most recently from 82ca06b to 5686042 Compare July 31, 2024 22:00
@kiashok kiashok force-pushed the kep4216-gc-labels branch 4 times, most recently from fab0a9f to a9b0c94 Compare September 29, 2024 23:22
@kiashok kiashok added this to the 2.1 milestone Nov 11, 2024
@kiashok kiashok force-pushed the kep4216-gc-labels branch 4 times, most recently from 6c83e62 to fefb511 Compare December 2, 2024 04:33
@kiashok kiashok force-pushed the kep4216-gc-labels branch 6 times, most recently from 830be53 to 792e097 Compare January 1, 2025 19:32
Adds support for image pull per runtime
class with the help of gc labels.
The image pull code path remains the same
but during UpdateImage() call, the image index
or manifest is walked to find the appropriate
platform, snapshot the image was unpacked for.
If such a match if found, find all matching
runtime handlers with identical platform and
snapshotter from CriConfig.RuntimePlatforms and
update containerd and cri image stores appropriately.
New entry for tuple (ref,runtimehandler) are made in
containerd metadata store and snapshot gc labels are
added to take reference on unpacked snapshot.
Further, image gc labels are also added to the root image
to ensure appropriate resource cleanup.
This approach also makes the image delete and reload code
paths simple.

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok kiashok force-pushed the kep4216-gc-labels branch 8 times, most recently from b406b5d to d65aec0 Compare January 2, 2025 07:36
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok kiashok force-pushed the kep4216-gc-labels branch 3 times, most recently from 06c7471 to 4abbfb9 Compare January 2, 2025 18:11
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@k8s-ci-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link

github-actions bot commented Apr 4, 2025

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Apr 4, 2025
@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Apr 11, 2025
@github-project-automation github-project-automation bot moved this from Needs Update to Done in Pull Request Review Apr 11, 2025
@dims dims reopened this May 1, 2025
@github-project-automation github-project-automation bot moved this from Done to Needs Triage in Pull Request Review May 1, 2025
@dims
Copy link
Member

dims commented May 1, 2025

@kiashok will you be picking this up again?

@k8s-ci-robot
Copy link

@kiashok: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerd-build fb15345 link true /test pull-containerd-build
pull-containerd-node-e2e fb15345 link true /test pull-containerd-node-e2e
pull-containerd-k8s-e2e-ec2 fb15345 link false /test pull-containerd-k8s-e2e-ec2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kiashok
Copy link
Contributor Author

kiashok commented May 6, 2025

Updated PR: #11807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants