Skip to content

plugins: add a plugin to set the xfs_quota for the container rootfs filesystem#10404

Closed
hxy88888 wants to merge 3 commits into
containerd:mainfrom
hxy88888:main
Closed

plugins: add a plugin to set the xfs_quota for the container rootfs filesystem#10404
hxy88888 wants to merge 3 commits into
containerd:mainfrom
hxy88888:main

Conversation

@hxy88888

Copy link
Copy Markdown

This commit is add a plugin to set the xfs_quota for the container rootfs filesystem, similar as docker option --storage-opt overlay2.size=20G

Discussions: #8978

Required:

  1. snapshot data dir, usually is container root dir, must xfs filesystem
  2. snapshoter is overlayfs
  3. linux/unix os

containerd config.toml:

[plugins]
  [plugins."io.containerd.rootquota.v1.xfs"]
    rootfs_quota = "10G"

@k8s-ci-robot

Copy link
Copy Markdown

Hi @hxy88888. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: hanxiangyuan <hanxiangyuan@jd.com>
@dcantah

dcantah commented Jul 16, 2024

Copy link
Copy Markdown
Member

I'm not sure a plugin is the right model here, at least one that's in-tree, but curious on other maintainer opinions. I haven't done a deep dive here, but is it possible for this to just be a new overlayfs snapshotter option that:

  1. Checks if the underlying root location of the snapshotter is mounted on an xfs filesystem
  2. If 1 is true, just sets the provided quota (supplied via the new overlayfs option) after mounting the overlayfs?

@k8s-ci-robot

Copy link
Copy Markdown

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: hanxiangyuan <hanxiangyuan@jd.com>
@mxpv mxpv added status/needs-update Awaiting contributor update status/needs-discussion Needs discussion and decision from maintainers labels May 1, 2025
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions Bot added the Stale label Jul 31, 2025
@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions Bot closed this Aug 7, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Pull Request Review Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants