Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 11, 2024

  • Remove hcsshim import from repo
    • un-exports GetOsVersion
  • Update windows matcher to not compare empty os version

full diff: containerd/platforms@v0.2.0...v0.2.1

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Comment on lines -67 to +66
func GetOsVersion(osVersionPrefix string) osversion.OSVersion {
func getOSVersion(osVersionPrefix string) osVersion {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is no longer exported; it was added in cfb30a3 (#8778)

But also was backported to 1.7, so made it into a release; #9069

@dmcgowan
Copy link
Member

- Remove hcsshim import from repo
    - un-exports GetOsVersion
- Update windows matcher to not compare empty os version

full diff: containerd/platforms@v0.2.0...v0.2.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title vendor: github.com/containerd/platforms main (v0.3.0-dev) vendor: github.com/containerd/platforms v0.2.1 Jun 11, 2024
@thaJeztah thaJeztah marked this pull request as ready for review June 11, 2024 22:55
@thaJeztah
Copy link
Member Author

Updated to v0.2.1 and moved out of draft 👍

@thaJeztah thaJeztah requested review from dmcgowan and kiashok June 12, 2024 00:27
@thaJeztah thaJeztah self-assigned this Jun 12, 2024
@thaJeztah thaJeztah requested a review from laurazard June 12, 2024 11:14
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid added this pull request to the merge queue Jun 12, 2024
Merged via the queue into containerd:main with commit 0de7043 Jun 12, 2024
@thaJeztah thaJeztah deleted the bump_platforms branch June 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants