Skip to content

[release/1.7] Fix Windows HPC working directory #10306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Jun 7, 2024
Merged

[release/1.7] Fix Windows HPC working directory #10306

dmcgowan merged 1 commit into from
Jun 7, 2024

Conversation

@anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Jun 6, 2024

Change in 989f1ec assumed a single
place (pkg/cri/sbserver) where this had to be fixed.

Commit in main branch for reference:
(cherry picked from commit c7ea06a)

@anmaxvl
[release/1.7]: HPC working directory fix in pkg/cri/server code
33b6293 
Change in 989f1ec assumed a single
place (pkg/cri/sbserver) where this had to be fixed.

Commit in main branch for reference:
(cherry picked from commit c7ea06a)

Signed-off-by: Maksim An <maksiman@microsoft.com>
@k8s-ci-robot
Copy link

k8s-ci-robot commented Jun 6, 2024

Hi @anmaxvl. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kiashok
kiashok approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@kiashok kiashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 895f104 into containerd:release/1.7 Jun 7, 2024
@anmaxvl anmaxvl deleted the hpc-work-dir branch June 10, 2024 16:58
@dmcgowan dmcgowan added area/cri Container Runtime Interface (CRI) impact/changelog labels Jun 12, 2024
@dmcgowan dmcgowan changed the title [release/1.7]: HPC working directory fix in pkg/cri/server code [release/1.7] Fix Windows HPC working directory Jun 12, 2024
@dmcgowan dmcgowan mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@henry118 henry118 henry118 approved these changes

@kiashok kiashok kiashok approved these changes

Assignees

No one assigned

Labels

area/cri Container Runtime Interface (CRI) impact/changelog needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anmaxvl @k8s-ci-robot @dmcgowan @henry118 @kiashok