Skip to content

Conversation

@thaJeztah
Copy link
Member

This updates the errdefs package to be an alias for the new errdefs module. This helps transitioning consumers to the new module, and makes sure that containerd v2 and v1 use the same definitions.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@thaJeztah thaJeztah self-assigned this May 26, 2024
@thaJeztah thaJeztah force-pushed the 1.7_migrate_to_errdefs_module branch 2 times, most recently from 6691ebe to 3ca9a44 Compare May 26, 2024 10:56
thaJeztah added 2 commits May 26, 2024 13:19
This updates the errdefs package to be an alias for the new errdefs module.
This helps transitioning consumers to the new module, and makes sure that
containerd v2 and v1 use the same definitions.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 1.7_migrate_to_errdefs_module branch from 3ca9a44 to 308341a Compare May 26, 2024 11:21
@thaJeztah thaJeztah marked this pull request as ready for review May 26, 2024 12:18
@thaJeztah thaJeztah requested review from AkihiroSuda and dmcgowan May 26, 2024 12:18
@thaJeztah
Copy link
Member Author

I'll do one for 1.6 as well; with that, all supported versions of the module should be using the same types

@dmcgowan dmcgowan merged commit be820ac into containerd:release/1.7 May 26, 2024
@thaJeztah thaJeztah deleted the 1.7_migrate_to_errdefs_module branch May 27, 2024 06:57
@dmcgowan dmcgowan changed the title [release/1.7] migrate errdefs package to github.com/containerd/errdefs module [release/1.7] Migrate errdefs package to github.com/containerd/errdefs Jun 4, 2024
@dmcgowan dmcgowan changed the title [release/1.7] Migrate errdefs package to github.com/containerd/errdefs [release/1.7] Migrate errdefs package to github.com/containerd/errdefs Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants