-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
Description
What is the problem you're trying to solve
Containerd 2.0 will remove the support for docker schema 1 images. To facilitate the transition, I am looking for ways to better expose its usage. One idea I have is to add a new label to docker schema 1 image in containerd v1.X.
Describe the solution you'd like
Here is my proposed implementation.
- We append a new label
converted=dockerV1if the image gets converted in https://github.com/containerd/containerd/blob/v1.7.2/pull.go#L276. In thefetchfunction, this can be easily determined. - Then, when the image metadata is stored, it will have that label so that
ctr imagescan query it. https://github.com/containerd/containerd/blob/v1.7.2/pull.go#L285 - CRI image pull calls
client.Pullin https://github.com/containerd/containerd/blob/v1.7.2/pkg/cri/server/image_pull.go#L183
Additional context
The label name can be further discussed. I am open to suggestion.
If people think this is a good solution, I will create a PR.
samuelkarp