fix: don't print to stdout when initializing console fails on Windows#66
Merged
estesp merged 1 commit intocontainerd:mainfrom Mar 13, 2023
Merged
fix: don't print to stdout when initializing console fails on Windows#66estesp merged 1 commit intocontainerd:mainfrom
estesp merged 1 commit intocontainerd:mainfrom
Conversation
e4a9c91 to
984533f
Compare
caarlos0
approved these changes
Oct 21, 2022
kzys
approved these changes
Mar 7, 2023
Member
dcantah
reviewed
Mar 7, 2023
dcantah
reviewed
Mar 9, 2023
dcantah
approved these changes
Mar 9, 2023
When stdin/err/out are redirected, console mode can't be changed. That's often expected & acceptable however, so we shouldn't print errors to stdout. Signed-off-by: Christian Muehlhaeuser <muesli@gmail.com>
Contributor
Author
Done. PTAL! |
estesp
approved these changes
Mar 13, 2023
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stdin/err/out are redirected, console mode can't be changed. That's often expected & acceptable however, so we shouldn't print errors to stdout.