Merged
Conversation
The solaris implementation is not used anywhere, and removed from most projects, so we may as well clean up the corresponding files here. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
^^ at least, I don't think we take solaris into account anymore in any of our other repositories; happy to close this one if there's concerns about this (or if we know there's actually still active development happening in this area). |
estesp
reviewed
Feb 14, 2022
Member
estesp
left a comment
There was a problem hiding this comment.
LGTM
Agree unless someone knows otherwise--seems solaris has been dropped from all the major container building blocks
dmcgowan
approved these changes
Mar 15, 2022
mxpv
approved these changes
Mar 21, 2022
This was referenced May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solaris implementation is not used anywhere, and removed from most projects, so we may as well clean up the corresponding files here.