Skip to content

Use Ioctl{SetPointerInt,GetInt} from golang.org/x/sys/unix on linux#42

Merged
estesp merged 1 commit intocontainerd:masterfrom
tklauser:linux-ioctl-x-sys-unix
Sep 24, 2020
Merged

Use Ioctl{SetPointerInt,GetInt} from golang.org/x/sys/unix on linux#42
estesp merged 1 commit intocontainerd:masterfrom
tklauser:linux-ioctl-x-sys-unix

Conversation

@tklauser
Copy link
Copy Markdown
Contributor

Use unix.IoctlSetPointerInt and unix.IoctlGetInt instead of manually
implementing them. This avoid the use of the unsafe package.

Use unix.IoctlSetPointerInt and unix.IoctlGetInt instead of manually
implementing them. This avoid the use of the `unsafe` package.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 5d7e141 into containerd:master Sep 24, 2020
@tklauser tklauser deleted the linux-ioctl-x-sys-unix branch September 25, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants