Enable Github Actions-based CI#36
Conversation
|
1.12 vendor broken.. passes on 1.13 looks like it's been a while since this repo has had a PR... |
|
yeah, as people have noted in other projects, |
other than building version.go12/ version.go13 based vendor trees... maybe we should skip that test on go n-1... oh hell NVM... :-) |
|
@estesp can you try rebasing this one? travis now tests go 1.13/1.14 |
Also add linting to CI and remove travis script entries that were no-ops (there are no tests for other platforms so the extra `go test` invocations with GOOS settings were not doing anything) Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
|
Updated |
|
CI is green now; I don't see the action running though; does that need configuration changes in the repository first? Or won't it run on this repository until after it's merged? |
|
They never run until the first merge and it exists in the "upstream" repo. That's why I always separate removing travis until we can verify and fix any nits with the actions first. |
| go get -u github.com/golangci/golangci-lint/cmd/golangci-lint | ||
| ( | ||
| cd "${GOPATH}/src/github.com/golangci/golangci-lint/cmd/golangci-lint" | ||
| git checkout v1.23.8 | ||
| go build -v && go install | ||
| ) |
There was a problem hiding this comment.
Not for this PR, but we could make use of go modules for these;
- change to a directory outside of the project (to prevent the go.mod and/or vendor directory from being updated)
- run
go get "github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANG_CI_VERSION}"
edit: although I see they don't recommend installing from source; https://golangci-lint.run/usage/install/#local-installation
Also add linting to CI and remove travis script entries that were no-ops
(there are no tests for other platforms so the extra
go testinvocations with GOOS settings were not doing anything)
Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com