Skip to content

Update golangci-lint action to v4 and linter to v1.57.1 #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuweid merged 1 commit into from
Mar 25, 2024
Merged

Update golangci-lint action to v4 and linter to v1.57.1 #330

fuweid merged 1 commit into from
Mar 25, 2024

Conversation

@austinvazquez
Copy link
Member

@austinvazquez austinvazquez commented Mar 22, 2024

Issue

CI is failing for linter errors

Description

This change updates golangci-lint GitHub action package to v4 and linter version to v1.57.1

@austinvazquez
Update golangci-lint action to v4 and linter to v1.57.1
0d51bda 
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez marked this pull request as ready for review March 22, 2024 06:30
fuweid
fuweid approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit e319d1b into containerd:main Mar 25, 2024
@austinvazquez austinvazquez deleted the update-golangci-lint branch March 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@austinvazquez @fuweid @dcantah