Upgrade GitHub actions CI workflow #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
commented
Oct 24, 2022
fdb3237 to
47630ee
Compare
Member
|
@AkihiroSuda do we lose cgroups v1 testing if we move to 22.04? I thought I remembered that 22.04 defaults to cgroups v2 but maybe I'm wrong. |
Member
Yes, so we need to use 20.04, not 22.04 |
Update actions runner OS image to Ubuntu 22.04. Update actions/checkout and actions/setup-go packages from v2 to v3. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
47630ee to
08db267
Compare
Member
Author
|
Thanks for the clarification @AkihiroSuda. Added a comment to remind the next person once Ubuntu 20.04 goes EOL. |
AkihiroSuda
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the GitHub action CI workflow to use the ubuntu-22.04 image since the ubuntu-18.04 image has been marked deprecated. Also updates the actions/checkout and actions/setup-go packages to the latest version.
Related issue: containerd/project#95
Signed-off-by: Austin Vazquez macedonv@amazon.com