Added OOM notification for Memory controller#115
Merged
crosbymichael merged 4 commits intocontainerd:masterfrom Nov 15, 2019
Merged
Added OOM notification for Memory controller#115crosbymichael merged 4 commits intocontainerd:masterfrom
crosbymichael merged 4 commits intocontainerd:masterfrom
Conversation
AkihiroSuda
reviewed
Nov 12, 2019
Member
Does kernel have this feature? Seems not https://facebookmicrosites.github.io/cgroup2/docs/memory-controller.html |
AkihiroSuda
reviewed
Nov 12, 2019
Contributor
Author
|
@AkihiroSuda Do we actually care about other events here? Coz we can easily filter it only by |
Member
|
Yes, but I agree it is not now |
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=========================================
- Coverage 36.34% 35.75% -0.6%
=========================================
Files 32 32
Lines 2102 2137 +35
=========================================
Hits 764 764
- Misses 1210 1245 +35
Partials 128 128
Continue to review full report at Codecov.
|
Contributor
Author
|
@AkihiroSuda You mean something like this? PTAL |
AkihiroSuda
reviewed
Nov 12, 2019
AkihiroSuda
reviewed
Nov 12, 2019
AkihiroSuda
reviewed
Nov 12, 2019
AkihiroSuda
approved these changes
Nov 13, 2019
14 tasks
Contributor
Author
|
@crosbymichael PTAL |
Member
|
rebase please :) |
254a491 to
d03d516
Compare
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Contributor
Author
|
@crosbymichael Done. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially Fixes #104
@crosbymichael @AkihiroSuda
So this Pr is on of the ideas I have on how we can implement
OOM notificationsincGroupv2.So, I see here at least two directions, we can implement
Inotify fdcheck right here and in case if we receiveinotifyevent, create new separate file foroom'sonly, and return that filefd.On other hand we can delegate it to next layers(containerd etc.)
What do you think of this approach?
Signed-off-by: bpopovschi zyqsempai@mail.ru