Skip to content

Add ToResources func for spec to v2.Resources#111

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:to-res
Nov 7, 2019
Merged

Add ToResources func for spec to v2.Resources#111
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:to-res

Conversation

@crosbymichael
Copy link
Member

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #111 into master will decrease coverage by 0.64%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   38.95%   38.31%   -0.65%     
==========================================
  Files          31       31              
  Lines        1961     1994      +33     
==========================================
  Hits          764      764              
- Misses       1069     1102      +33     
  Partials      128      128
Impacted Files Coverage Δ
v2/cpu.go 0% <0%> (ø) ⬆️
v2/utils.go 12.24% <0%> (-3.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a026e7e...8e6ae5f. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 3ecfbc4 into containerd:master Nov 7, 2019
@crosbymichael crosbymichael deleted the to-res branch November 7, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants