Skip to content

Bump google.golang.org/genproto to use isolated rpc submodule#550

Merged
bswartz merged 1 commit into
container-storage-interface:masterfrom
liggitt:genproto
Aug 14, 2023
Merged

Bump google.golang.org/genproto to use isolated rpc submodule#550
bswartz merged 1 commit into
container-storage-interface:masterfrom
liggitt:genproto

Conversation

@liggitt

@liggitt liggitt commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

What type of PR is this?

Dependency update

What this PR does / why we need it:

Updates genproto to use the isolated submodule. This reduces overall dependency count and avoids future issues with ambiguous imports. See googleapis/go-genproto#1015 for details.

Does this PR introduce an API-breaking change?:

none

Signed-off-by: Jordan Liggitt <liggitt@google.com>
@liggitt

liggitt commented Aug 10, 2023

Copy link
Copy Markdown
Contributor Author

cc @saad-ali

@jdef jdef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jdef

jdef commented Aug 11, 2023

Copy link
Copy Markdown
Member

Cc @bswartz

@bswartz bswartz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bswartz bswartz merged commit 80d5310 into container-storage-interface:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants