Skip to content

Move volume mount group feature GA#509

Merged
saad-ali merged 1 commit into
container-storage-interface:masterfrom
gnufied:fix-move-mount-ga
Oct 20, 2022
Merged

Move volume mount group feature GA#509
saad-ali merged 1 commit into
container-storage-interface:masterfrom
gnufied:fix-move-mount-ga

Conversation

@gnufied

@gnufied gnufied commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Drop alpha from volume_mount_group feature.

@jdef

jdef commented Jun 8, 2022

Copy link
Copy Markdown
Member

is this the first time we've promoted something from alpha to GA? i'm wondering if there's a compatibility impact w/ respect to completely dropping the alpha annotations vs. setting them to false. maybe i'm overthinking this. has anyone tested interactions between older bindings (w/ alpha set) against newer bindings (w/o alpha)?

@gnufied

gnufied commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

This is another instance #499 when we moved things over from alpha to GA. I will look into compatibility aspects of when we move a feature from alpha to GA.

@gnufied

gnufied commented Oct 17, 2022

Copy link
Copy Markdown
Contributor Author

@jdef So I ran e2e of k8s by updating kubernetes with my version of CSI driver and let driver run a released version of CSI with alpha APIs. And all e2es are still passing:

  should pass FSGroup to CSI driver if it is set in pod and driver supports VOLUME_MOUNT_GROUP                                                                                                                                                               
    should not pass FSGroup to CSI driver if it is set in pod and driver does not supports VOLUME_MOUNT_GROUP                                                                                                                                                         

Is that enough as signal that dropping alpha annotation does not break anything?

@jingxu97

Copy link
Copy Markdown

/cc @saad-ali

@saad-ali saad-ali added this to the v1.7 milestone Oct 19, 2022

@jdef jdef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saad-ali saad-ali merged commit 910d60f into container-storage-interface:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants