Skip to content

doc: add issue and PR templates#504

Merged
saad-ali merged 2 commits into
container-storage-interface:masterfrom
andyzhangx:template
Oct 20, 2022
Merged

doc: add issue and PR templates#504
saad-ali merged 2 commits into
container-storage-interface:masterfrom
andyzhangx:template

Conversation

@andyzhangx

Copy link
Copy Markdown
Contributor

It's better have a template for issues and PRs, we could refine the templates later.
/assign @jdef @saad-ali

@jdef

jdef commented Mar 30, 2022

Copy link
Copy Markdown
Member

Thanks for the PR.

The templates seem a bit k8s-centric, and this is not a k8s project. Nor does it use k8s PR robots.

I'm open to the idea of templates, but I think we should probably scrub e.g. links to k8s-specific things.

Comment thread .github/ISSUE_TEMPLATE/bug-report.md Outdated
Comment thread .github/ISSUE_TEMPLATE/support.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@andyzhangx

Copy link
Copy Markdown
Contributor Author

I have removed the k8s related things, PTAL, thanks.

@saad-ali saad-ali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@saad-ali saad-ali merged commit e4c4553 into container-storage-interface:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants