Skip to content

Fix double prints#671

Merged
djc merged 3 commits intoconsole-rs:mainfrom
spoutn1k:fix-double-prints
Dec 11, 2024
Merged

Fix double prints#671
djc merged 3 commits intoconsole-rs:mainfrom
spoutn1k:fix-double-prints

Conversation

@spoutn1k
Copy link
Copy Markdown
Contributor

Fix for #670.

Will work on a reproducing the issue and creating a test for it, but in the meantime this fixes the issue experimentally.

@spoutn1k
Copy link
Copy Markdown
Contributor Author

spoutn1k commented Nov 27, 2024

use indicatif::{MultiProgress, ProgressBar, ProgressDrawTarget};

fn main() {
    let display_manager = MultiProgress::new();
    let progress = display_manager.add(ProgressBar::with_draw_target(
        None,
        ProgressDrawTarget::stderr(),
    ));

    progress.println("This should print once");
}

Minimal program reproducing the issue.

@spoutn1k
Copy link
Copy Markdown
Contributor Author

The failed check comes from a license change that is out of my control. Should I ignore or roll in a fix @djc ?

@djc
Copy link
Copy Markdown
Member

djc commented Dec 2, 2024

The failed check comes from a license change that is out of my control. Should I ignore or roll in a fix @djc ?

Submitted fixes for these in #674.

@djc djc merged commit 6417492 into console-rs:main Dec 11, 2024
@djc
Copy link
Copy Markdown
Member

djc commented Dec 11, 2024

Thanks!

@spoutn1k spoutn1k deleted the fix-double-prints branch December 11, 2024 12:54
@spoutn1k
Copy link
Copy Markdown
Contributor Author

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants