feat: allow constructing and setting the progress bar len to None#664
Merged
djc merged 2 commits intoconsole-rs:mainfrom Nov 12, 2024
Merged
feat: allow constructing and setting the progress bar len to None#664djc merged 2 commits intoconsole-rs:mainfrom
None#664djc merged 2 commits intoconsole-rs:mainfrom
Conversation
djc
reviewed
Nov 11, 2024
Member
djc
left a comment
There was a problem hiding this comment.
I think this makes sense, thanks.
djc
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For situations where the length of a progress bar can only be discovered after some processing, it might be more appropriate to show an empty bar rather than a full one of length 0 (
0/0is represented with a ratio of1.0).This PR introduces a new constructor,
ProgressBar::empty(), and a new method,ProgressBar::unset_length(). These two allow library users to have a length ofNone, which is represented as a ratio of0.0, achieving the empty state.