[feature request] adding {percent_precise} style key#628
[feature request] adding {percent_precise} style key#628djc merged 1 commit intoconsole-rs:mainfrom OmarTawfik-forks:precision-precise
{percent_precise} style key#628Conversation
The existing `{percent}` is rendered as an integer, which means it is not very useful for large data sets, as it rarely changes.
I suggest adding a new `{percent_precise}` (a non-breaking change?) that would render it with additional precision. For example, 3 fraction digits, as demonstrated by the test added here.
An earlier proposal to add precision to variables was rejected (#552), and AFAIK, there is no way to customize this without taking over rendering.
I think it would work well with existing variables like `elapsed_precise`, `eta_precise`.
Thanks for considering!
djc
left a comment
There was a problem hiding this comment.
Seems okay. @chris-laplante what do you think?
(Note that this can be done using a custom ProgressTracker implementation.)
I think it's a common enough use case that we shouldn't force people to use |
|
@djc @chris-laplante |
|
More or less by request: #629. |
|
@djc looks like the deployment failed (job) 😞 |
It is unrelated to your changes - it failed a few days ago as well: #631 |
The existing
{percent}is rendered as an integer, which means it is not very useful for large data sets, as it rarely changes.I suggest adding a new
{percent_precise}(a non-breaking change?) that would render it with additional precision. For example 3 fraction digits, as demonstrated by the test added here.An earlier proposal to add precision to variables was rejected (#552), and AFAIK, there is no way to customize this without taking over rendering. I think this proposal would work well with existing variables like
elapsed_precise,eta_precise.Thanks for considering!