Skip to content

chore: pin once_cell<1.21 to enforce MSRV#248

Closed
remi-dupre wants to merge 1 commit intoconsole-rs:mainfrom
remi-dupre:fix-msrv
Closed

chore: pin once_cell<1.21 to enforce MSRV#248
remi-dupre wants to merge 1 commit intoconsole-rs:mainfrom
remi-dupre:fix-msrv

Conversation

@remi-dupre
Copy link
Contributor

@remi-dupre remi-dupre commented Mar 11, 2025

Latest once_cell version only supports Rust >= 1.70 :

$ cargo update
$ cargo check
error: package `once_cell v1.21.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.66.1
Either upgrade to rustc 1.70 or newer, or use
cargo update -p once_cell@1.21.0 --precise ver
where `ver` is the latest version of `once_cell` supporting rustc 1.66.1

EDIT : BTW, 1.21 has no fixes or any change relevant to us : https://github.com/matklad/once_cell/blob/master/CHANGELOG.md#1210

@djc
Copy link
Member

djc commented Mar 12, 2025

Merged #249 instead. We shouldn't impose a < requirement on downstream users.

@djc djc closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants