Fix size check for envelope prefix (32bit build)#888
Closed
mikhailv wants to merge 1 commit intoconnectrpc:mainfrom
Closed
Fix size check for envelope prefix (32bit build)#888mikhailv wants to merge 1 commit intoconnectrpc:mainfrom
mikhailv wants to merge 1 commit intoconnectrpc:mainfrom
Conversation
This commit updates the size check in `makeEnvelopePrefix` to fix compilation error `connect@v1.19.0/envelope.go:378:24: math.MaxUint32 (untyped int constant 4294967295) overflows int` for 32-bit build. Signed-off-by: Mikhail Vazhnov <michael.vazhnov@gmail.com>
78de59f to
376c42e
Compare
Author
|
oh, fix is already in pull requests: #887 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the size check in
makeEnvelopePrefixto fix compilation errorconnect@v1.19.0/envelope.go:378:24: math.MaxUint32 (untyped int constant 4294967295) overflows intfor 32-bit build.Related issue: #886