Conversation
Signed-off-by: Josh Humphries <2035234+jhump@users.noreply.github.com>
61f0f7c to
2358f3a
Compare
jhump
commented
Sep 13, 2024
Comment on lines
+171
to
+172
| // We never setup a request body, so it's effectively already closed. | ||
| // So nothing else to do. |
Member
Author
There was a problem hiding this comment.
Unrelated, but I was reading this code and confused at first why it does nothing to close the body. And it's because we haven't set one yet: if d.requestSent is false then the request body is still http.NoBody. So I added a comment for future me :)
akshayjshah
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message had a copy+pasta bug where it was showing the wrong prefix. This resulted in possibly very confusing error message where it complained that the content-type was wrong, but then said it was expecting exactly what it actually got.