Only send a serialized Status in the gRPC protocol if it has details#713
Merged
jhump merged 2 commits intoconnectrpc:mainfrom Mar 19, 2024
Merged
Only send a serialized Status in the gRPC protocol if it has details#713jhump merged 2 commits intoconnectrpc:mainfrom
jhump merged 2 commits intoconnectrpc:mainfrom
Conversation
|
|
jhump
reviewed
Mar 19, 2024
Member
jhump
left a comment
There was a problem hiding this comment.
Makes sense to me. I'll run the CI workflows to make sure everything passes the test and lint jobs. @emcfarlane, any thoughts or concerns?
emcfarlane
reviewed
Mar 19, 2024
Contributor
emcfarlane
left a comment
There was a problem hiding this comment.
lgtm! Minor comments, thanks.
jhump
approved these changes
Mar 19, 2024
emcfarlane
approved these changes
Mar 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the gRPC protocol, Connect will always serialize a
Statusproto and return it in theGrpc-Status-Details-Binheader. This differs from the grpc-go behavior, which is to only emit that header if theStatushas a non-emptyDetailslist. The remaining properties ofStatus(messageandcode) are still returned via dedicated headers, so returning the encodedStatusmessage is redundant.This PR aligns Connect's gRPC protocol with the
grpc-gobehavior, which also reduces the wire size of error responses in the common case that no details are provided. I chose not to match their behavior ofpanicing when marshalling fails 😉 .