Revise code mappings per latest changes to spec#706
Merged
Conversation
jhump
commented
Mar 12, 2024
| assert.Nil(t, err) | ||
| defer resp.Body.Close() | ||
| assert.Equal(t, resp.StatusCode, http.StatusNotFound) | ||
| assert.Equal(t, resp.StatusCode, http.StatusNotImplemented) |
Member
Author
There was a problem hiding this comment.
This is one case where this mapping makes a lot more sense: when the server receives an unrecognized content-encoding, it returns an "unimplemented" status error. And 501 makes way more sense than 404. (Ideally it would be 415, but let's take what we can get 😆)
akshayjshah
approved these changes
Mar 12, 2024
Contributor
akshayjshah
left a comment
There was a problem hiding this comment.
Looks great! Somehow I expected this to be a more involved change.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reconciles the implementation in this repo with the recent adjustments to HTTP<->Connect code mappings (connectrpc/connectrpc.com#130).
The gRPC and Connect mappings from HTTP code to RPC code are now aligned, so I've unified them into a single function.