Skip to content

Reduce scope of err var in response content-type checks#681

Merged
jhump merged 1 commit intomainfrom
jh/reduce-scope-of-err-var
Feb 8, 2024
Merged

Reduce scope of err var in response content-type checks#681
jhump merged 1 commit intomainfrom
jh/reduce-scope-of-err-var

Conversation

@jhump
Copy link
Member

@jhump jhump commented Feb 8, 2024

This also formats the grpc version of the check so it is consistent with the other two.

Addresses comment in prior PR: #679 (comment)

Copy link
Contributor

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jhump jhump merged commit cc86f64 into main Feb 8, 2024
@jhump jhump deleted the jh/reduce-scope-of-err-var branch February 8, 2024 21:38
@jhump jhump added the ignore-for-release Exclude from release notes label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants