Merged
Conversation
Contributor
|
Strong +1 from me. |
akshayjshah
approved these changes
Feb 8, 2024
Contributor
|
@jhump thanks! Will debug this testcase 😅 |
Contributor
|
That's 3 of 4 current maintainers in favor, so the motion passes - congrats, @emcfarlane! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes adding @emcfarlane (from Buf) to the list of maintainers. Per Connect's governance policy, this also makes Ed one of the handful of maintainers with a vote on Connect RFCs.
Ed has done the lion's share of recent maintenance and improvements in this codebase (as well as in otelconnect), and he is already a maintainer in several related packages (authn, cors, and vanguard). He is an expert in all three of the protocols (as well as in RPC<-> REST transcoding), has made numerous high-quality contributions to the code, and is already a valuable resource for answering questions in Slack and in GitHub issues.
I am in support of this. @akshayjshah, @bufdev, @mattrobenolt, what do you think?