Only use trailers-only response in grpc-web when there are no custom headers#677
Merged
Only use trailers-only response in grpc-web when there are no custom headers#677
Conversation
akshayjshah
approved these changes
Feb 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled this commit into the conformance repo to verify that this change is compatible with the official gRPC-Web JS client. In fact, I added some conformance test cases around it (connectrpc/conformance#770) to verify that a gRPC-Web client will correctly accept both forms of "empty" response (for both unary and streams):
The only issue with the gRPC-Web JS client was that it doesn't like it when in-body trailers contains a key more than once. It doesn't fail, but later values overwrite earlier ones instead of it merging all of the values. (I went ahead and filed a bug for it: grpc/grpc-web#1399. It's trivial to fix, so I might open a pull request, too.)