chore: adapt to the new API for NamedTopology builders and runtimes#8331
Conversation
| return Objects.equals(sources, queryPlan.sources) | ||
| && Objects.equals(sink, queryPlan.sink) | ||
| && Objects.equals(physicalPlan, queryPlan.physicalPlan) | ||
| && Objects.equals(runtimeId, queryPlan.runtimeId) |
There was a problem hiding this comment.
just a small fix on the side that I kept in here
| private final Map<QueryId, PersistentQueryMetadata> persistentQueries = new ConcurrentHashMap<>(); | ||
| private final Map<QueryId, QueryMetadata> allLiveQueries = new ConcurrentHashMap<>(); | ||
| private final Map<SourceName, QueryId> createAsQueries = new ConcurrentHashMap<>(); | ||
| private final Map<SourceName, Set<QueryId>> insertQueries = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
again, just a small refactoring that I figured we may as well pull into this PR since it's so small
|
Walker Carlson (@wcarlson5) Rohan (@rodesai) I'm working on breaking up that one large PR into smaller chunks that we can start to merge right away, and unblock some other work, please take a look |
|
looks like you have a compilation error |
|
Walker Carlson (@wcarlson5) this isn't going to compile/pass the PR build until this gets synced over to ccs-kafka, ,and the sync job is currently blocked on conflicts due to the 3.2 version bump. I ran the tests locally with the above commit and verified they pass so we should be good to merge this right away after the sync job goes through |
9b00089 to
84094e7
Compare
84094e7 to
791c375
Compare
791c375 to
c05a08a
Compare
Extracting some self-contained pieces of the mega-PR #8219 before I tackle any of the large refactoring that was suggested.
This PR just prepares only the necessary changes for us to finally merge https://github.com/apache/kafka/pull/11272 without breaking the build. Since we were already starting up an empty KafkaStreams, the only changes we need here are to get the
TopologyBuilderfrom this KafkaStreams