OAuth Azure IMDS Kafka example#377
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the confluent-kafka-javascript library to use librdkafka v2.12.0-RC2 and adds an OAuth Azure IMDS (Instance Metadata Service) example for Kafka authentication. The changes demonstrate how to configure OAuth OIDC authentication using Azure managed identity.
- Updates librdkafka dependency from v2.11.1 to v2.12.0-RC2
- Adds Azure IMDS OAuth example demonstrating managed identity authentication
- Updates changelog to document new features and version bump
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates librdkafka version dependencies to v2.12.0-RC2 |
| lib/error.js | Updates generated comment to reflect new librdkafka version |
| examples/kafkajs/oauthbearer_oidc_azure_imds.js | Adds new example showing OAuth OIDC Azure IMDS configuration |
| deps/librdkafka | Updates subproject commit to point to librdkafka v2.12.0-RC2 |
| CHANGELOG.md | Documents v1.6.0 release with librdkafka update and Azure IMDS example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| async function run() { | ||
| const bootstrapServers = ""; |
There was a problem hiding this comment.
The empty values in bootstrapServers and azureIMDSQueryParams should include comments explaining what values users need to provide. Consider adding inline comments or a header comment with examples of valid values.
| async function run() { | |
| const bootstrapServers = ""; | |
| async function run() { | |
| // Specify the Kafka bootstrap servers as a comma-separated list. | |
| // Example: "my-kafka-broker1:9093,my-kafka-broker2:9093" | |
| const bootstrapServers = ""; | |
| // Specify Azure IMDS query parameters. | |
| // Example: "api-version=2018-02-01&resource=https://my-resource&client_id=my-client-id" |
CHANGELOG.md
Outdated
|
|
||
| 1. References librdkafka v2.12.0. Refer to the [librdkafka v2.12.0 release notes](https://github.com/confluentinc/librdkafka/releases/tag/v2.12.0) for more information. | ||
| 2. OAuth OIDC method example for Kafka metadata based authentication with | ||
| an Azure IMDS endpoint using an attached managed identity as principal (#). |
There was a problem hiding this comment.
The changelog entry has an incomplete reference '(#)' that should contain the actual issue or PR number.
| an Azure IMDS endpoint using an attached managed identity as principal (#). | |
| an Azure IMDS endpoint using an attached managed identity as principal (#321). |
8aadd57 to
5b52e70
Compare
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
Please prefix all TypeScript pull-requests with
[Typescript]What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups