Skip to content

Custom log filtering#95

Merged
adams85 merged 6 commits intomasterfrom
feature/logfilter
Aug 21, 2024
Merged

Custom log filtering#95
adams85 merged 6 commits intomasterfrom
feature/logfilter

Conversation

@adams85
Copy link
Contributor

@adams85 adams85 commented Jul 30, 2024 •
edited
Loading

Describe the purpose of your pull request

Provides a new, more convenient way (ConfigCatClientOptions.LogFilter) for consumers to specify custom log event filter logic.

Also, brings some performance improvements (reduced memory allocation) around log messages and evaluation log building:

ConfigCat.Client.Benchmarks.MatrixTestBenchmark

Diff Method Mean Error Allocated
Old (net6.0, LogInfo = false) MatrixTests_ConfigV6 16.14 ms 0.149 ms 11.75 MB
New (net6.0, LogInfo = false) 16.17 ms (0%) 0.084 ms 11.53 MB (-2%)
Old (net48, LogInfo = false) MatrixTests_ConfigV6 52.67 ms 0.157 ms 17.33 MB
New (net48, LogInfo = false) 52.53 ms (0%) 0.318 ms 16.77 MB (-3%)
Old (net6.0, LogInfo = true) MatrixTests_ConfigV6 49.48 ms 0.204 ms 62.76 MB
New (net6.0, LogInfo = true) 48.92 ms (-1%) 0.444 ms 62.07 MB (-1%)
Old (net48, LogInfo = true) MatrixTests_ConfigV6 138.43 ms 1.004 ms 77.65 MB
New (net48, LogInfo = true) 136.28 ms (-2%) 0.842 ms 73.94 MB (-5%)

Related issues (only if applicable)

https://trello.com/c/IxCFbq2j

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner July 30, 2024 17:49
endret
endret requested changes Jul 30, 2024
View reviewed changes
@adams85 adams85 mentioned this pull request Jul 31, 2024
Merged
4 tasks
endret
endret requested changes Aug 1, 2024
View reviewed changes
endret
endret requested changes Aug 1, 2024
View reviewed changes
@adams85 adams85 force-pushed the feature/logfilter branch from 70c5c3f to c4e59ed Compare August 2, 2024 18:03
endret
endret approved these changes Aug 2, 2024
View reviewed changes
src/ConfigCatClient/Utils/LazyString.cs

public bool IsValueCreated => this.argsOrValue is null or string;

public override string ToString() => Value ?? string.Empty;
Copy link
Contributor

@endret endret Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@adams85 adams85 force-pushed the feature/logfilter branch from 648ff6a to e607ac4 Compare August 21, 2024 07:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@adams85 adams85 merged commit 74b650d into master Aug 21, 2024
@adams85 adams85 deleted the feature/logfilter branch August 21, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@endret endret endret approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adams85 @endret