Merged
Conversation
4 tasks
endret
approved these changes
Aug 20, 2024
# Conflicts: # src/ConfigCat.Client.Tests/UtilsTests.cs # src/ConfigCatClient/ConfigService/DefaultConfigFetcher.cs
z4kn4fein
approved these changes
Aug 21, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
The main goal of the PR is to make the SDK trimmable and AOT-friendly. To make this happen, it was necessary to switch to source generation of JSON serialization metadata. (Besides this, source generation of regular expressions has also been enabled for improving performance in .NET 8+ applications.)
To support Unity WebGL,
HttpConfigFetcherhas been refactored into two classes (DefaultConfigFetcherandHttpClientConfigFetcher) so that the actual HTTP request logic can be replaced with a user-defined implementation. (This was done by following the pattern used in the JS SDK.) As a bonus, this also improves the testability of the SDK by allowing consumers to mock the HTTP communication in their tests.)Since Unity WebGL doesn't support multi-threading, a minimal platform abstraction layer (
PlatformCompatibilityOptionsandTaskShim) has also been introduced.The PR adds two new sample apps (BlazorWasm, MAUI) and some scripts to show how to make the SDK work in Unity WebGL.
Related issues (only if applicable)
n/a
Requirement checklist (only if applicable)