Conversation
|
…pose them to the user (EvaluationDetails.ErrorCode)
4d3f5de to
d2f0b0c
Compare
endret
approved these changes
Apr 1, 2024
d9034e5 to
b24c576
Compare
…and expose them to the user (RefreshResult.ErrorCode)
7fcf0bb to
63bc9be
Compare
63bc9be to
73ab47d
Compare
|
sigewuzhere
approved these changes
Apr 29, 2024
z4kn4fein
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Define error codes (
EvaluationErrorCode,RefreshErrorCode) and expose them to the user (EvaluationDetails.ErrorCode,RefreshResult.ErrorCode) so they can reliably identify the error type without resorting to guess it by checking the error message (see also: open-feature/dotnet-sdk-contrib#119 (comment))The PR also proposes a new hook named
ConfigFetchedwhich could be used to observe config fetching-related errors even when refreshing is done by the SDK.Related issues (only if applicable)
https://trello.com/c/mU63054x
Requirement checklist (only if applicable)