Correct pending request vs. Dispose behavior in HttpClientConfigFetcher#110
Merged
Correct pending request vs. Dispose behavior in HttpClientConfigFetcher#110
Conversation
151d31a to
350aaff
Compare
|
endret
approved these changes
May 31, 2025
|
|
||
| private HttpClient EnsureClient(TimeSpan timeout) | ||
| { | ||
| if (this.httpClient is not { } httpClientObj) |
Contributor
There was a problem hiding this comment.
I'm not a huge fan of the pattern matching, but I can live with that.
Member
There was a problem hiding this comment.
Why are you not a huge fan of pattern matching?
Contributor
Author
There was a problem hiding this comment.
If not pattern matching in general, but the is { }/is not { } syntax might not be the most straightforward, @endret is right about that.
Problem is its usage is pretty widespread already (I found around 15 occurrences).
If you'd like to improve this, I'm open to rewrite these to the more verbose but clearer syntax. But let's do that in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
The implementation of
HttpClientConfigFetcheris somewhat sloppy currently becauseDisposeandFetchAsync, which are not (and can't really be) synchronized,HttpClientinstances afterDispose.This PR tightens things up in this area.
Related issues (only if applicable)
n/a
How to test? (only if applicable)
n/a
Security (only if applicable)
n/a
Requirement checklist (only if applicable)