Conversation
…for improved precision and resistance to system/user clock adjustments
e12b22c to
6e294e5
Compare
69a0883 to
468a5ff
Compare
…ent with other SDKs in Auto Poll + offline mode
….getConfig + improve clientReady
d75f2f4 to
9a7ac8f
Compare
…ous cache sync ups
dbffbb1 to
6c4eb33
Compare
6c4eb33 to
4e772ad
Compare
|
z4kn4fein
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe the purpose of your pull request
This PR makes some corrections and improvements around config services:
Stopwatch.GetTimestamp) instead of system clock (DateTime.UtcNow) for scheduling poll iterations in Auto Polling mode for improved precision and resistance to system clock adjustments (time sync, daylight saving, user initiated clock adjustments, etc.)forceRefreshAsyncto report failure and log a warning in offline mode only when the client is not configured to use an external cache. (Low impact behavioral BC.)ClientReadyevent consistent with other SDKs in Auto Polling mode. When the client is offline,ClientReadyis emitted as soon as the initial sync with the external cache completes. (Low impact behavioral BC.)ClientReadyevent and theWaitForReadyAsyncmethod as the previous description was misleading.ConfigChangedevent when the local cache is updated as a result of synchronization with the external cache. (Low impact behavioral BC.)configChangedonce per config refresh operation, eliminate race conditions around cache write, and improve performance in high concurrency situations by deduplicating config refresh instead of config fetch operation only.HttpClientConfigFetcher(TheW/prefix should not be stripped from the received ETag because other SDKs don't do that).Related issues (only if applicable)
https://trello.com/c/XZdBOLY1
https://trello.com/c/mU63054x
How to test? (only if applicable)
n/a
Security (only if applicable)
n/a
Requirement checklist (only if applicable)