Conversation
|
Thanks for these additions ! I'm not a reviewer, but just a suggestion :
@[EventPayload]
class Stripe::TaxRate
include JSON::Serializable
include StripeMethods
add_retrieve_method
getter id : String
getter inclusive : Bool
getter object : String?
getter customer : String?
getter active : Bool
@[JSON::Field(converter: Time::EpochConverter)]
getter created : Time
getter description : String?
getter jurisdiction : String?
getter metadata : Hash(String, String)?
getter percentage : Float32?
end |
|
Like @rmarronnier (thanks!) - You can look through our help methods to use those to reduce repetitions and maybe remove some files. When that is done, this looks very good! Thanks, @xaviablaza, and @rjmssevilla for the help! I appreciate it. |
544db52 to
b162b79
Compare
|
@confact Ready for review, could you take a look? |
|
@xaviablaza, the test seems to fail on the |
|
@confact All right, I've namespaced the |
|
@xaviablaza, the tests passed! Great job! I will merge now. |
Description
@rjmssevilla and I patched this shard quite a bit and wanted to match what we're using in the production to the upstream. The changes are as follows:
Stripe::Coupon.retrieveto retrieve aStripe::Coupongiven its idSignatureVerificationErroraround the namespaceStripeas we referenceStripe::SignatureVerificationErroroutside of the shardconfigurationattribute toStripe::BillingPortal::Session.create_sessionto create billing portal sessions with different configurationssubscription_data,allow_promotion_codes,metadata, anddiscountsattributes when creating aStripe::Checkout::SessionmetadatatoStripe::Subscriptionto get the metadata created from theStripe::Checkout::Session