Update event.cr to make request.id nilable.#41
Merged
confact merged 1 commit intoconfact:masterfrom Aug 11, 2021
Merged
Conversation
Stripe events are not always the same. "invoice.payment_succeeded" has an `event.request.id` of `nil` when it occurs at the end of a "invoice.payment_action_required" workflow. When it occurs otherwise it has an id.
Contributor
|
Thanks for this @vectorselector ! Also, could you keep the corresponding issue (#39) open as long this PR is waiting to be merged ? (makes things easier for reviewers ;-) ) |
Owner
|
LGTM, some attributes seems to need to be nil, even if the documentation doesn't mention it. Got same issue myself on some of the objects. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stripe events are not always the same. "invoice.payment_succeeded" has an
event.request.idofnilwhen it occurs at the end of a "invoice.payment_action_required" workflow. When it occurs otherwise it has an id.Here's an example of an event.request sub-object: