Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
We have a working fix for |
|
So re-rendering with |
|
Thanks I just did. |
|
@jakirkham @AdriaanRol @alexcjohnson do you have any idea why these builds are failing? Might be related to microsoft/Qcodes#540 |
recipe/meta.yaml
Outdated
| - PyQt5 ==5.7.1 | ||
| - sip ==4.19 | ||
| - QtPy ==1.2.0 | ||
| - h5py ==2.6.0 |
There was a problem hiding this comment.
Why is everything so tightly pinned like this? Seems like this will cause issues.
Also the indentation appears to be incorrect w.r.t run.
There was a problem hiding this comment.
I was just following whatever happened in https://github.com/QCoDeS/Qcodes/blob/v0.1.3/requirements.txt
I fixed the indentation.
There was a problem hiding this comment.
Those are normally used to create identical dev environments not specify versions for user installs. Please use this list, which is the same one pip would use.
There was a problem hiding this comment.
Also may want these extras. Though that is up to you as a user can always install them if they wish.
There was a problem hiding this comment.
Thanks for the comments!
I have updated the versions and packages, but the error is still the same.
|
Sort of a dumb question, but is the license file in the source? |
|
They changed the extension of the license, I've corrected it, thanks for spotting. This conda-forge/pyvisa-feedstock#6 probably solves the dependency issue. |
|
If you aren't wanting to dive into building everything for Python 3.6 right now, you can add a |
|
Good point! Pinning py35 didn't help though. I am going to leave this here as it is now. I welcome the |
Fix the merge of #1