Skip to content

Apply Python 3.11 migration#152

Merged
chrisburr merged 2 commits intoconda-forge:mainfrom
chrisburr:3.11
Oct 26, 2022
Merged

Apply Python 3.11 migration#152
chrisburr merged 2 commits intoconda-forge:mainfrom
chrisburr:3.11

Conversation

@chrisburr
Copy link
Copy Markdown
Member

@chrisburr chrisburr commented Oct 25, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Copy Markdown

conda-forge-linter commented Oct 25, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@chrisburr chrisburr mentioned this pull request Oct 25, 2022
Merged
5 tasks
@chrisburr
Copy link
Copy Markdown
Member Author

chrisburr commented Oct 25, 2022

Cross-compilation needs conda-forge/cross-python-feedstock#56

@nicoddemus
Copy link
Copy Markdown
Member

nicoddemus commented Oct 25, 2022

Thanks @chrisburr!

I see conda-forge/cross-python-feedstock#56 was merged, do we need to trigger something here now?

@chrisburr
Copy link
Copy Markdown
Member Author

chrisburr commented Oct 25, 2022

Looks like there are some cross-compilation issues to work out for Python 3.11, I'll look into it.

@chrisburr chrisburr mentioned this pull request Oct 25, 2022
Merged
@chrisburr
Copy link
Copy Markdown
Member Author

chrisburr commented Oct 25, 2022

@conda-forge/pytest This should be ready to go (feel free to merge the bot's PR instead if you'd prefer, I just used this package for testing the migrator manually).

@h-vetinari h-vetinari mentioned this pull request Oct 26, 2022
Merged
@h-vetinari
Copy link
Copy Markdown
Member

h-vetinari commented Oct 26, 2022 •
edited
Loading

It would be good to merge this as soon as feasible because a lot of feedstocks in the migration depend on this, but the migrator doesn't take that into account. This is because unfortunately the dependency graph for the migrator is built without test-only dependencies (which pytest almost always is), as that can lead to circularities (e.g. package A depending on B, and package B using A as a test-only dependency; this is not a build-level circularity, "just" on on recipe-level one).

@chrisburr chrisburr merged commit a268677 into conda-forge:main Oct 26, 2022
@chrisburr chrisburr deleted the 3.11 branch October 26, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flub flub Awaiting requested review from flub flub is a code owner

@goanpeca goanpeca Awaiting requested review from goanpeca goanpeca is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

@nicoddemus nicoddemus Awaiting requested review from nicoddemus nicoddemus is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisburr @conda-forge-linter @nicoddemus @h-vetinari