Skip to content

numpy 1.24.0#285

Merged
h-vetinari merged 4 commits intoconda-forge:mainfrom
h-vetinari:bump
Dec 19, 2022
Merged

numpy 1.24.0#285
h-vetinari merged 4 commits intoconda-forge:mainfrom
h-vetinari:bump

Conversation

@h-vetinari
Copy link
Copy Markdown
Member

@h-vetinari h-vetinari commented Dec 19, 2022

bot errored:

 - could not hash URL template 'https://github.com/numpy/numpy/releases/download/v{{ version }}/numpy-{{ version }}.tar.gz'

@conda-forge-linter
Copy link
Copy Markdown

conda-forge-linter commented Dec 19, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Copy Markdown
Member Author

h-vetinari commented Dec 19, 2022

@mattip @rgommers
Looks like there are three new failures for pypy, though just on osx. Additionally pypy on ppc seems to be timing out. I guess I can switch those back to cross-compilation if necessary.

All three errors seem to be related to perhaps overzealously prettifying the serialization of polynomials, so I think it would also be fine to skip these tests. Details below.

=================================== FAILURES ===================================
__________________________ TestPrintOptions.test_str ___________________________
[gw2] darwin -- Python 3.8.13 $PREFIX/bin/python

self = <numpy.polynomial.tests.test_printing.TestPrintOptions object at 0x00007f9c0008d600>

    def test_str(self):
        p = poly.Polynomial([1/2, 1/7, 1/7*10**8, 1/7*10**9])
>       assert_equal(str(p), '0.5 + 0.14285714 x + 14285714.28571429 x**2 '
                             '+ (1.42857143e+08) x**3')
E       AssertionError:
E       Items are not equal:
E        ACTUAL: '0.5 + 0.14285714·x + 14285714.28571429·x² + (1.42857143e+08)·x³'
E        DESIRED: '0.5 + 0.14285714 x + 14285714.28571429 x**2 + (1.42857143e+08) x**3'

p          = Polynomial([5.00000000e-01, 1.42857143e-01, 1.42857143e+07, 1.42857143e+08], domain=[-1,  1], window=[-1,  1], symbol='x')
self       = <numpy.polynomial.tests.test_printing.TestPrintOptions object at 0x00007f9c0008d600>

[...]/lib/pypy3.8/site-packages/numpy/polynomial/tests/test_printing.py:483: AssertionError
_____________________ TestPrintOptions.test_switch_to_exp ______________________
[gw2] darwin -- Python 3.8.13 $PREFIX/bin/python

self = <numpy.polynomial.tests.test_printing.TestPrintOptions object at 0x00007f9c0008d0c0>

    def test_switch_to_exp(self):
        for i, s in enumerate(SWITCH_TO_EXP):
            with printoptions(precision=i):
                p = poly.Polynomial([1.23456789*10**-i
                                     for i in range(i//2+3)])
>               assert str(p).replace('\n', ' ') == s
E               AssertionError: assert '1.0 + (1.0e-... (1.0e-02)·x²' == '1.0 + (1.0e-...1.0e-02) x**2'
E                 - 1.0 + (1.0e-01) x + (1.0e-02) x**2
E                 ?                ^             ^ ^^^
E                 + 1.0 + (1.0e-01)·x + (1.0e-02)·x²
E                 ?                ^             ^ ^

i          = 0
p          = Polynomial([1.23456789, 0.12345679, 0.01234568], domain=[-1,  1], window=[-1,  1], symbol='x')
s          = '1.0 + (1.0e-01) x + (1.0e-02) x**2'
self       = <numpy.polynomial.tests.test_printing.TestPrintOptions object at 0x00007f9c0008d0c0>

[...]/lib/pypy3.8/site-packages/numpy/polynomial/tests/test_printing.py:517: AssertionError
_______________________ TestPrintOptions.test_non_finite _______________________
[gw2] darwin -- Python 3.8.13 $PREFIX/bin/python

self = <numpy.polynomial.tests.test_printing.TestPrintOptions object at 0x00007f9c0008cf00>

    def test_non_finite(self):
        p = poly.Polynomial([nan, inf])
>       assert str(p) == 'nan + inf x'
E       AssertionError: assert 'nan + inf·x' == 'nan + inf x'
E         - nan + inf x
E         ?          ^
E         + nan + inf·x
E         ?          ^

p          = Polynomial([nan, inf], domain=[-1,  1], window=[-1,  1], symbol='x')
self       = <numpy.polynomial.tests.test_printing.TestPrintOptions object at 0x00007f9c0008cf00>

[...]/lib/pypy3.8/site-packages/numpy/polynomial/tests/test_printing.py:521: AssertionError

@mattip
Copy link
Copy Markdown

mattip commented Dec 19, 2022

Weird. So PyPy is prettifying the polynomial where CPython does not? Perhaps some terminal discovery routine is behaving differently, so PyPy renders a utf-8 terminal and CPython renders ascii?

@rgommers
Copy link
Copy Markdown
Contributor

rgommers commented Dec 19, 2022

so I think it would also be fine to skip these tests

Skiping, and reporting the issue upstream, sounds about right to me.

@h-vetinari h-vetinari mentioned this pull request Dec 19, 2022
Closed
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Dec 19, 2022
This was referenced Dec 19, 2022
Closed
Merged
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 19, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: failed
  • azure: passed

Thus the PR was not passing and not merged.

@h-vetinari h-vetinari merged commit 498d99b into conda-forge:main Dec 19, 2022
@h-vetinari h-vetinari deleted the bump branch December 19, 2022 21:21
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Dec 19, 2022

Would suggest raising the bot issue here (if that hasn't already happened). Would be good to get that sorted out

Thanks for shepherding this one through (manually)! 🙏

@h-vetinari
Copy link
Copy Markdown
Member Author

h-vetinari commented Dec 20, 2022

I seem to have lost the rights to retrigger builds in travis even for feedstocks for which I am maintainer. They also cannot be restarted through the github CI. This means my hands are tied (a pretty clear regression in maintenance capabilities), so someone else will have to restart those.

@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Dec 20, 2022

May need to relogin to Travis and run their repo sync

@h-vetinari h-vetinari mentioned this pull request Dec 20, 2022
Open
@h-vetinari
Copy link
Copy Markdown
Member Author

h-vetinari commented Dec 20, 2022

May need to relogin to Travis and run their repo sync

Interesting. No idea why they'd use my user credentials (I was shown as logged in too!) after some years, but I did that and it worked. Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@pelson pelson Awaiting requested review from pelson pelson is a code owner

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees

No one assigned

Labels

automerge Merge the PR when CI passes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@h-vetinari @conda-forge-linter @mattip @rgommers @jakirkham