Skip to content

nodejs v24.3.0#397

Merged
xhochy merged 10 commits intoconda-forge:mainfrom
h-vetinari:24
Jul 10, 2025
Merged

nodejs v24.3.0#397
xhochy merged 10 commits intoconda-forge:mainfrom
h-vetinari:24

Conversation

@h-vetinari
Copy link
Copy Markdown
Member

Builds on #396, draft for now

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Jul 8, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16161259924. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Copy Markdown
Member Author

There's also a missing include somewhere on osx that I haven't yet had time to look at.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Jul 8, 2025

This probably needs bumping the SDK to 11.0+. osx-arm64 built fine for me locally.

@xhochy xhochy marked this pull request as ready for review July 8, 2025 12:13
@xhochy
Copy link
Copy Markdown
Member

xhochy commented Jul 9, 2025

It's weird the same code works on linux-64 but fails on linux-aarch64. 2.28 should already be a sufficiently new glibc.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Jul 9, 2025

Found it, it is related to the build_platform build; will confirm locally and then push.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16176838592. Examine the logs at this URL for more detail.

@xhochy
Copy link
Copy Markdown
Member

xhochy commented Jul 9, 2025

@h-vetinari Any idea on how to do this in a linter-friendly way?

@h-vetinari
Copy link
Copy Markdown
Member Author

@h-vetinari Any idea on how to do this in a linter-friendly way?

I think the right fix would be conda-forge/linux-sysroot-feedstock#87. Beyond that, one can also introduce a variable for "sysroot" and then use {{ foo }}_{{ build_platform }}. But the easiest for now is to use the skip you had set up in conda-forge/conda-smithy#2304 ;-)

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16181080128. Examine the logs at this URL for more detail.

@xhochy xhochy merged commit a9e60ef into conda-forge:main Jul 10, 2025
10 checks passed
@h-vetinari h-vetinari deleted the 24 branch July 10, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants