Skip to content

icepyx v2.0.2#24

Merged
JessicaS11 merged 5 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:2.0.2_h7d6166
Mar 17, 2026
Merged

icepyx v2.0.2#24
JessicaS11 merged 5 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:2.0.2_h7d6166

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Mar 16, 2026 •
edited by weiji14
Loading

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by grayskull shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by grayskull but not in the meta.yaml:

  • setuptools-scm
  • python ${{ python_min }}.*
  • dask-core
  • python >=${{ python_min }}

Packages found in the meta.yaml but not found by grayskull:

  • setuptools_scm
  • python 3.11.*
  • dask-core <2025.1.0
  • python >=3.11

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/23154044955 - please use this URL for debugging.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Mar 16, 2026

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.

Here's what I've got...

For recipe/recipe.yaml:

  • ❌ context.python_min has a value that is interpreted as a floating-point number. Please quote it (like "3.11") to ensure that it is interpreted as string and preserved exactly.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23154797417. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Mar 16, 2026

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

weiji14
weiji14 reviewed Mar 16, 2026
View reviewed changes
Comment thread recipe/recipe.yaml
run:
- backoff
- dask-core <2025.1.0
- dask-core
Copy link
Copy Markdown
Member

@weiji14 weiji14 Mar 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream icepyx depends on dask[dataframe], which in v2026.1.2, added a dependency on pyarrow>=16 (dask/dask#12258). This causes the following import check failure at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1488734&view=logs&j=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc&t=9eb77fd2-8ddd-5444-8fc0-71cb28dcb736&l=1325

 Installing test environment
 ✔ Successfully updated the test environment
 Traceback (most recent call last):
   File "$SRC_DIR/conda_build_script.py", line 1, in <module>
     import icepyx
   File "$PREFIX/lib/python3.11/site-packages/icepyx/__init__.py", line 3, in <module>
     from icepyx.core.query import GenQuery, Query
   File "$PREFIX/lib/python3.11/site-packages/icepyx/core/query.py", line 27, in <module>
     from icepyx.core.visualization import Visualize
   File "$PREFIX/lib/python3.11/site-packages/icepyx/core/visualization.py", line 10, in <module>
     import dask.dataframe as dd
   File "$PREFIX/lib/python3.11/site-packages/dask/dataframe/__init__.py", line 25, in <module>
     from dask.dataframe.dask_expr import (
   File "$PREFIX/lib/python3.11/site-packages/dask/dataframe/dask_expr/__init__.py", line 3, in <module>
     from dask.dataframe.dask_expr import datasets
   File "$PREFIX/lib/python3.11/site-packages/dask/dataframe/dask_expr/datasets.py", line 10, in <module>
     from dask.dataframe.dask_expr._collection import new_collection
   File "$PREFIX/lib/python3.11/site-packages/dask/dataframe/dask_expr/_collection.py", line 14, in <module>
     import pyarrow as pa
 ModuleNotFoundError: No module named 'pyarrow'

I reckon we don't include pyarrow as a required dependency here yet, but pin to dask<2026.1.2 in test.requires so that users using older versions of dask don't need to pull in pyarrow yet. This does mean however that users installing dask>=2026.1.2 have to install pyarrow manually.

@weiji14
Do manual import checks with dask<2026.1.2 to avoid pyarrow requirement
e9db689 
Xref dask/dask#12258. Remove this workaround after pyarrow is a necessary dependency.
@weiji14 weiji14 mentioned this pull request Mar 16, 2026
Closed
1 task
weiji14
weiji14 reviewed Mar 16, 2026
View reviewed changes
Comment thread recipe/recipe.yaml Outdated
Copy link
Copy Markdown
Member

@weiji14 weiji14 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hitting into another error on Python 3.11 with the holoviews dependency 😅 Details at conda-forge/holoviews-feedstock#120. We could pin to holoviews>=1.13.0 to avoid it, but best to fix it using a repodata patch so that others don't hit into it.

Copy link
Copy Markdown
Member

@weiji14 weiji14 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we can safely pin to holoviews>=1.13.0, because that's when Python 3.10+ compatibility starts (we're pinning to python>=3.11 in icepyx).

weiji14
weiji14 approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge when there's a second approval, since there's some tricky dependency changes here that could use a second eye (not icepyx's fault, just other packages). Or will merge directly tomorrow if nobody disagrees 🙂

@JessicaS11
Copy link
Copy Markdown
Contributor

JessicaS11 commented Mar 17, 2026

Thanks for all the fixes/updates and thorough documentation/explanation of them, @weiji14. It looks great to me, so I'll go ahead and approve/merge.

@JessicaS11 JessicaS11 merged commit e7aa58b into conda-forge:main Mar 17, 2026
4 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 2.0.2_h7d6166 branch March 17, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JessicaS11 JessicaS11 JessicaS11 approved these changes

@weiji14 weiji14 weiji14 approved these changes

@lsetiawan lsetiawan Awaiting requested review from lsetiawan lsetiawan is a code owner

@mfisher87 mfisher87 Awaiting requested review from mfisher87 mfisher87 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@regro-cf-autotick-bot @conda-forge-admin @JessicaS11 @weiji14